Fix the remaining static analyzer warnings in TestNetscapePlugIn: Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference) CRASH(); ^~~~~~~ Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH' ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \ ^~~~~~~~~~~~~~~~ Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj') return obj->pluginTest->NPP_SetWindow(window); ^~~~~~~~~~~~~~~ 2 warnings generated. The first issue requires using __builtin_trap() on clang/gcc builds. The second is just a matter of adding an early return.
Created attachment 266670 [details] Patch v1
Comment on attachment 266670 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266670&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:47 > + *(int *)(uintptr_t)0xbbadbeef = 0; \ > + __builtin_trap(); /* More reliable, but doesn't say BBADBEEF. */ \ This comment is not relevant any more, __builtin_trap crashes are perfectly identifiable. I don't think that we need the 0xbbadbeef variant at all. That said, WTF also still does the same, so we should probably be consistent.
(In reply to comment #2) > Comment on attachment 266670 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266670&action=review > > > Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:47 > > + *(int *)(uintptr_t)0xbbadbeef = 0; \ > > + __builtin_trap(); /* More reliable, but doesn't say BBADBEEF. */ \ > > This comment is not relevant any more, __builtin_trap crashes are perfectly > identifiable. I don't think that we need the 0xbbadbeef variant at all. > > That said, WTF also still does the same, so we should probably be consistent. +1 for consistency.
Comment on attachment 266670 [details] Patch v1 Clearing flags on attachment: 266670 Committed r193509: <http://trac.webkit.org/changeset/193509>
All reviewed patches have been landed. Closing bug.