Bug 155392 - run-webkit-tests: handle Darwin framework/library environment variables more consistently
Summary: run-webkit-tests: handle Darwin framework/library environment variables more ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-12 09:07 PST by David Kilzer (:ddkilzer)
Modified: 2016-03-12 12:00 PST (History)
7 users (show)

See Also:


Attachments
Patch v1 (5.66 KB, patch)
2016-03-12 09:17 PST, David Kilzer (:ddkilzer)
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-03-12 09:07:00 PST
These changes will make it possible to pass through the following environment variables from the run-webkit-tests command-line:

DYLD_FRAMEWORK_PATH
DYLD_LIBRARY_PATH
__XPC_DYLD_FRAMEWORK_PATH
__XPC_DYLD_LIBRARY_PATH
Comment 1 David Kilzer (:ddkilzer) 2016-03-12 09:17:02 PST
Created attachment 273837 [details]
Patch v1
Comment 2 Daniel Bates 2016-03-12 10:08:24 PST
Comment on attachment 273837 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=273837&action=review

> Tools/ChangeLog:13
> +        __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to list of

Nit: "to list" => "to the list"

> Tools/ChangeLog:14
> +        variables to keep from the run-webkit-test envrionment.

Nit: envrionment => environment
Comment 3 David Kilzer (:ddkilzer) 2016-03-12 12:00:25 PST
Committed r198066: <http://trac.webkit.org/changeset/198066>