Bug 156609 - REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class after removing ENABLE(STREAM)
Summary: REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 123667
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-14 16:12 PDT by David Kilzer (:ddkilzer)
Modified: 2016-04-14 17:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (3.11 KB, patch)
2016-04-14 16:14 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-04-14 16:12:52 PDT 
This code was left behind when ENABLE(STREAM) was removed in November 2013.
Comment 1 David Kilzer (:ddkilzer) 2016-04-14 16:14:43 PDT 
Created attachment 276446 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2016-04-14 16:15:32 PDT 
Here's where the code was removed for Bug 123667:

Committed r158956: <http://trac.webkit.org/changeset/158956>
Comment 3 Brent Fulgham 2016-04-14 16:33:01 PDT 
Comment on attachment 276446 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=276446&action=review

This looks good. r=me.

> Source/WebCore/fileapi/FileReaderLoader.cpp:-65
> -    , m_rangeEnd(0)

I would be tempted to convert these to C++11 initializers, but you don't need to do that for this change.
Comment 4 WebKit Commit Bot 2016-04-14 17:23:19 PDT 
Comment on attachment 276446 [details]
Patch v1

Clearing flags on attachment: 276446

Committed r199569: <http://trac.webkit.org/changeset/199569>
Comment 5 WebKit Commit Bot 2016-04-14 17:23:24 PDT 
All reviewed patches have been landed.  Closing bug.