Bug 184358 - Adopt non-deprecated CGColorSpace API
Summary: Adopt non-deprecated CGColorSpace API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-06 08:39 PDT by Brent Fulgham
Modified: 2019-08-07 17:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2019-08-07 16:11 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-04-06 08:39:14 PDT 
We are using a deprecated CGColorSpace creation method:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
            cgColorSpace = adoptCF(CGColorSpaceCreateWithICCProfile(colorSpaceData.get()));
#pragma clang diagnostic pop

We should adopt the newer API (I think this is CGColorSpaceCreateICCBased)
Comment 1 Radar WebKit Bug Importer 2018-04-06 09:17:51 PDT 
<rdar://problem/39239671>
Comment 2 Kate Cheney 2019-08-07 16:11:41 PDT 
Created attachment 375762 [details]
Patch
Comment 3 WebKit Commit Bot 2019-08-07 16:52:26 PDT 
Comment on attachment 375762 [details]
Patch

Clearing flags on attachment: 375762

Committed r248396: <https://trac.webkit.org/changeset/248396>
Comment 4 WebKit Commit Bot 2019-08-07 16:52:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2019-08-07 17:02:18 PDT 
Yay first bug!