Bug 22754 - Keyboard shortcut for Element finder
Summary: Keyboard shortcut for Element finder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Enhancement
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-09 01:56 PST by Jaakko Holster
Modified: 2009-11-19 18:13 PST (History)
2 users (show)

See Also:


Attachments
[PATCH] Fix (1.80 KB, patch)
2009-11-19 16:38 PST, Brian Weinstein
darin: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaakko Holster 2008-12-09 01:56:38 PST
I wish the "Select an element in the page to inspect it" button (magnifier icon in the bottom toolbar) has a keyboard shortcut, similar to Firebug's cmd+shift+c. I bet for many web developers it is one of the most used function. Maybe the Develop menu could contain "Select element" item, so people were able to set a shortcut.
Comment 1 Joseph Pecoraro 2009-07-14 18:11:55 PDT
Is this a Safari feature or a WebKit one?  I have a feeling this is mostly going to be Safari that has to hook in.  Maybe WebKit has to provide a hook?  I'll see if I can get someone to mention what would need to be done.
Comment 2 Brian Weinstein 2009-11-19 15:41:48 PST
This should be possible at the WebKit level, just like (Command/Control)-F takes you to the top right search of the Inspector.

I'm not sure the shortcut to use here, maybe (Command/Control)-I, for inspect?
Comment 3 Brian Weinstein 2009-11-19 15:42:31 PST
Or we could use Command-Shift-C, like Firebug users are used to. I can lay the groundwork, but some other opinions on this would be nice.
Comment 4 Brian Weinstein 2009-11-19 16:35:58 PST
Since this is a request from Firebug switchers, probably should give them the shortcut they are used to - patch coming momentarily.
Comment 5 Brian Weinstein 2009-11-19 16:38:24 PST
Created attachment 43533 [details]
[PATCH] Fix
Comment 6 Brian Weinstein 2009-11-19 18:13:23 PST
Landed in r51225. I'm not sure if we need to support a better shortcut that works more of the time, but I'll close the bug for now.