Bug 24856 - run-javascriptcore-tests should run testapi on Windows
Summary: run-javascriptcore-tests should run testapi on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on: 24857
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-26 14:16 PDT by Adam Roben (:aroben)
Modified: 2009-08-13 09:03 PDT (History)
2 users (show)

See Also:

Attachments
copy testapi.js to $WebKitOutputDir (3.26 KB, patch)
2009-03-26 14:17 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
patch to enable testapi on Windows (2.50 KB, patch)
2009-03-26 14:26 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Fix Bug 24856: run-javascriptcore-tests should run testapi on Windows (1.13 KB, patch)
2009-08-13 08:23 PDT, Adam Roben (:aroben) 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-03-26 14:16:27 PDT 
Currently, run-javascriptcore-tests only runs testapi on Mac. It should run it on Windows, too!
Comment 1 Adam Roben (:aroben) 2009-03-26 14:17:29 PDT 
Created attachment 28986 [details]
copy testapi.js to $WebKitOutputDir
Comment 2 Adam Roben (:aroben) 2009-03-26 14:26:25 PDT 
Created attachment 28988 [details]
patch to enable testapi on Windows

We can't land this patch until bug 24857 is fixed, so not marking for review yet.
Comment 3 Adam Roben (:aroben) 2009-03-26 14:28:39 PDT 
Comment on attachment 28986 [details]
copy testapi.js to $WebKitOutputDir

Landed as r42016
Comment 4 Adam Roben (:aroben) 2009-08-13 08:23:28 PDT 
Created attachment 34743 [details]
Fix Bug 24856: run-javascriptcore-tests should run testapi on Windows

<https://bugs.webkit.org/show_bug.cgi?id=24856>

Reviewed by NOBODY (OOPS!).

* Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
the AppleWinWebKit configuration.
---
 2 files changed, 12 insertions(+), 1 deletions(-)
Comment 5 Adam Roben (:aroben) 2009-08-13 09:03:54 PDT 
Fixed in r47199. http://trac.webkit.org/changeset/47199