Bug 28163 - bugzilla-tool: scm module should not import bugzilla module
Summary: bugzilla-tool: scm module should not import bugzilla module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 13:17 PDT by David Kilzer (:ddkilzer)
Modified: 2009-08-10 14:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (3.01 KB, patch)
2009-08-10 13:17 PDT, David Kilzer (:ddkilzer)
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-08-10 13:17:12 PDT
Created attachment 34505 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool:
(parse_bug_id): Added.  Moved from CommitMessage.parse_bug_id()
in scm module.
* Scripts/modules/scm.py: Removed import of bugzilla module.
(CommitMessage.parse_bug_id): Deleted.
---
 3 files changed, 23 insertions(+), 12 deletions(-)
Comment 1 Adam Barth 2009-08-10 13:22:17 PDT
Comment on attachment 34505 [details]
Patch v1

Where did the loop go?
Comment 2 David Levin 2009-08-10 13:29:04 PDT
Comment on attachment 34505 [details]
Patch v1

The loop went away because it now searches the whole message at once instead of one line at a time.
commit_message.message() vs self.message_lines
Comment 3 David Levin 2009-08-10 13:30:13 PDT
And of course, please fix this on commit: http://webkit.org/b/00000
Comment 4 David Kilzer (:ddkilzer) 2009-08-10 14:50:47 PDT
(In reply to comment #3)
> And of course, please fix this on commit: http://webkit.org/b/00000

It's already fixed locally.  Thanks.
Comment 5 David Kilzer (:ddkilzer) 2009-08-10 14:53:55 PDT
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/scm.py
Committed r47005

http://trac.webkit.org/changeset/47005