Bug 28393 - check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
Summary: check-webkit-style: add check for use of std::max()/std::min() instead of MAX...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-17 10:20 PDT by David Kilzer (:ddkilzer)
Modified: 2010-03-25 01:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (4.90 KB, patch)
2009-08-17 12:39 PDT, David Kilzer (:ddkilzer)
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-08-17 10:20:40 PDT
* SUMMARY
The std::max() and std::min() template methods should be preferred over the MAX()/MIN() macros since they're typesafe and since they may be used to automatically static_cast<>() their arguments using the std::max<type>() and std::min<type>() variants.

* NOTES
See Bug 28355.
Comment 1 David Kilzer (:ddkilzer) 2009-08-17 12:39:00 PDT
Created attachment 34986 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2009-08-17 13:33:44 PDT
Committed r47385: <http://trac.webkit.org/changeset/47385>
Comment 3 David Kilzer (:ddkilzer) 2009-08-17 13:33:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Adam Barth 2010-03-25 01:34:26 PDT
Committed r56510: <http://trac.webkit.org/changeset/56510>