Bug 28601 - bugzilla-tool post-commits posts commits backwards
Summary: bugzilla-tool post-commits posts commits backwards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-20 22:39 PDT by Adam Barth
Modified: 2009-09-01 19:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (3.74 KB, patch)
2009-09-01 17:56 PDT, David Kilzer (:ddkilzer) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-08-20 22:39:08 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=24696
Comment 1 David Kilzer (:ddkilzer) 2009-08-20 22:49:30 PDT 
Committed as http://trac.webkit.org/changeset/47563
Comment 2 David Kilzer (:ddkilzer) 2009-08-20 22:50:44 PDT 
(In reply to comment #1)
> Committed as http://trac.webkit.org/changeset/47563

Please ignore this comment.  It was meant for Bug 28485.
Comment 3 David Kilzer (:ddkilzer) 2009-08-20 22:53:15 PDT 
I think this change to scm.py fixes that:

             elif '..' in commitish:
-                commit_ids += self.run_command(['git', 'rev-list', commitish]).splitlines()
+                commit_ids += reversed(self.run_command(['git', 'rev-list', commitish]).splitlines())
Comment 4 Adam Barth 2009-08-20 22:56:29 PDT 
> I think this change to scm.py fixes that:

Cool!  Now we just need a unittest.  :)
Comment 5 David Kilzer (:ddkilzer) 2009-09-01 17:56:55 PDT 
Created attachment 38903 [details]
Patch v1
Comment 6 Adam Barth 2009-09-01 18:07:58 PDT 
Comment on attachment 38903 [details]
Patch v1

Awesome.  :)
Comment 7 David Kilzer (:ddkilzer) 2009-09-01 19:27:22 PDT 
Committed r47953: <http://trac.webkit.org/changeset/47953>