Created attachment 39960 [details] Patch v1 Reviewed by NOBODY (OOPS!). The "Generate 64-bit Export File" build phase script built the WebKit.LP64.exp export file used to link 64-bit WebKit. Instead of having a separate build phase script, move its generation into DerivedSources.make where WebCore.exp is generated. Note that because of VPATH usage in DerivedSources.make WebCore.LP64.exp had to be renamed to WebCore.LP64.base.exp. * DerivedSources.make: Added a rule to make WebCore.LP64.exp. * WebCore.LP64.base.exp: Renamed from WebCore/WebCore.LP64.exp. * WebCore.xcodeproj/project.pbxproj: Removed the "Generate 64-bit Export File" build phase script. --- 5 files changed, 44 insertions(+), 37 deletions(-)
(In reply to comment #0) > The "Generate 64-bit Export File" build phase script built the > WebKit.LP64.exp export file used to link 64-bit WebKit. Instead Already changed "WebKit.LP64.exp" to "WebCore.LP64.exp" and "WebKit" to "WebCore" above.
Comment on attachment 39960 [details] Patch v1 Clearing the review? flag based on comments from a private discussion with Mark.
Created attachment 39969 [details] Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h
Created attachment 39970 [details] Move "Generate 64-bit Export File" build phase script into DerivedSources.make
Comment on attachment 39969 [details] Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h r=me
Comment on attachment 39970 [details] Move "Generate 64-bit Export File" build phase script into DerivedSources.make r=me
Committed r48685: <http://trac.webkit.org/changeset/48685> Committed r48686: <http://trac.webkit.org/changeset/48686>
Committed r48686: <http://trac.webkit.org/changeset/48686>