Bug 30171 - fast/dom/Window/window-postmessage-clone.html fails on Windows
Summary: fast/dom/Window/window-postmessage-clone.html fails on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://build.webkit.org/results/Windo...
Keywords: LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2009-10-07 09:22 PDT by Adam Roben (:aroben)
Modified: 2009-10-07 09:51 PDT (History)
1 user (show)

See Also:


Attachments
Export DateInstance::info in a way that works on Windows (2.79 KB, patch)
2009-10-07 09:47 PDT, Adam Roben (:aroben)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-10-07 09:22:10 PDT
fast/dom/Window/window-postmessage-clone.html has been failing on Windows since it was added. Apparently the Date object is getting converted to a vanilla Object when passed through postMessage.
Comment 1 Adam Roben (:aroben) 2009-10-07 09:24:04 PDT
It looks like this test is failing:

        if (value.isObject() && asObject(value)->inherits(&DateInstance::info))
            return SerializedScriptValueData(SerializedScriptValueData::DateType, asDateInstance(value)->internalNumber());

<http://trac.webkit.org/browser/trunk/WebCore/bindings/js/SerializedScriptValue.cpp?rev=49216#L478>

It seems that &DateInstance::info in WebCore and &DateInstance::info in JSC don't return the same pointer, so the inherits() test fails. I think this is a linking problem.
Comment 2 Adam Roben (:aroben) 2009-10-07 09:38:09 PDT
I think I have a fix.
Comment 3 Adam Roben (:aroben) 2009-10-07 09:47:09 PDT
Created attachment 40799 [details]
Export DateInstance::info in a way that works on Windows
Comment 4 Adam Roben (:aroben) 2009-10-07 09:51:10 PDT
Committed r49247: <http://trac.webkit.org/changeset/49247>