Created attachment 40821 [details] Patch v1 Catching up to Mac.
Comment on attachment 40821 [details] Patch v1 rs=me. If you need an in-depth windows review then you should get a windows person to look at this too, but it looks right as far as I can tell! looks like you didn't use prepare-ChangeLog --bug 12345 Or maybe you used bugzilla-tool create-bug and that doesn't know how to fix ChangeLogs yet? Donno. Obviously the ChangeLogs will need to be fixed, but I assume you plan to commit this yourself anyway.
(In reply to comment #1) > (From update of attachment 40821 [details]) > looks like you didn't use prepare-ChangeLog --bug 12345 > Or maybe you used bugzilla-tool create-bug and that doesn't know how to fix > ChangeLogs yet? Donno. The latter. > Obviously the ChangeLogs will need to be fixed, but I assume you plan to commit > this yourself anyway. Yes. Should I set cq- on patches that I upload when I plan to land them myself? Thanks for reviewing!
Committed r49299: <http://trac.webkit.org/changeset/49299>