Bug 31124 - Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Summary: Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar
Depends on: 31414
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-04 09:40 PST by Adam Roben (:aroben)
Modified: 2009-11-13 20:55 PST (History)
5 users (show)

See Also:


Attachments
Patch (47.28 KB, patch)
2009-11-04 09:40 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared (57.37 KB, patch)
2009-11-13 12:29 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared (56.70 KB, patch)
2009-11-13 12:40 PST, Adam Roben (:aroben)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-11-04 09:40:13 PST
Created attachment 42489 [details]
Patch

We should tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared so that they can modify the objects as needed.
Comment 1 Adam Roben (:aroben) 2009-11-04 09:46:52 PST
<rdar://problem/7214190&7214207>
Comment 2 Adam Roben (:aroben) 2009-11-04 15:58:26 PST
Comment on attachment 42489 [details]
Patch

After talking with Sam Weinig and John Sullivan, I'm going to first revise our WebKit SPI to use objects to represent worlds instead of unsigned integers. Then I'll redo this patch on top of that change.
Comment 3 Adam Roben (:aroben) 2009-11-13 12:29:57 PST
Created attachment 43190 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Comment 4 Adam Roben (:aroben) 2009-11-13 12:35:25 PST
Comment on attachment 43190 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

Whoops, there's a double ChangeLog in WebKit/win/ChangeLog. Fixed locally.
Comment 5 Adam Roben (:aroben) 2009-11-13 12:40:54 PST
Created attachment 43192 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Comment 6 Dave Hyatt 2009-11-13 15:25:40 PST
Comment on attachment 43192 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

r=me
Comment 7 Adam Roben (:aroben) 2009-11-13 15:49:42 PST
Committed r50973: <http://trac.webkit.org/changeset/50973>
Comment 8 Dimitri Glazkov (Google) 2009-11-13 20:55:56 PST
Chromium port fix landed as: http://trac.webkit.org/changeset/50993.

Please have mercy on us Chromium people.