Bug 31125 - REGRESSION (r47121): bugzilla-tool create-bug raises exception after entering bug description
Summary: REGRESSION (r47121): bugzilla-tool create-bug raises exception after entering...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 28251 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-04 09:45 PST by Adam Roben (:aroben)
Modified: 2009-11-05 08:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2009-11-04 09:45 PST, Adam Roben (:aroben) 		ddkilzer: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-11-04 09:45:12 PST 
Created attachment 42490 [details]
Patch

It looks like this:

 % bugzilla-tool create-bug --cc hyatt@apple.com,sam@webkit.org HEAD
Bug title: Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Bug comment (hit ^D on blank line to end):
We should tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared so that they can modify the objects as needed.
Traceback (most recent call last):
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 917, in <module>
    main()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 914, in main
    return tool.main()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 909, in main
    return command_object.execute(command_options, command_args, self)
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 636, in execute
    self.create_bug_from_commit(options, args, tool)
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 583, in create_bug_from_commit
    (bug_title, comment_text) = self.prompt_for_bug_title_and_comment()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 628, in prompt_for_bug_title_and_comment
    raise
TypeError: exceptions must be classes or instances, not NoneType
Comment 1 Eric Seidel (no email) 2009-11-04 10:38:31 PST 
I wonder if this is a dupe of either bug 30537 or bug 28251.
Comment 2 David Kilzer (:ddkilzer) 2009-11-04 10:40:20 PST 
Comment on attachment 42490 [details]
Patch

r=me
Comment 3 Eric Seidel (no email) 2009-11-04 10:41:26 PST 
Comment on attachment 42490 [details]
Patch

ChangeLog looks wrong, but otherwise looks fine.  Does create-bug know how to fix a ChangeLog (since I assume you created this with create-bug)?
Comment 4 Adam Roben (:aroben) 2009-11-04 11:04:44 PST 
(In reply to comment #3)
> (From update of attachment 42490 [details])
> ChangeLog looks wrong

Do you mean because it says "OOPS!"? Or is there something else wrong about it?

> Does create-bug know how to fix a ChangeLog

create-bug doesn't touch ChangeLogs.

> (since I assume you created this with create-bug)?

I did.
Comment 5 Eric Seidel (no email) 2009-11-04 11:15:17 PST 
Yes, the only thing "Wrong" with the ChangeLog is the missing bug link, etc.  which prepare-changeLog --bug 31125 would know how to provide for you, and create-bug should be taught how to fill in for you too. :)
Comment 6 Adam Roben (:aroben) 2009-11-05 08:35:10 PST 
*** Bug 28251 has been marked as a duplicate of this bug. ***
Comment 7 Adam Roben (:aroben) 2009-11-05 08:43:56 PST 
Committed r50565: <http://trac.webkit.org/changeset/50565>