Bug 31479 - Make websocket tests work on Windows
Summary: Make websocket tests work on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-13 11:28 PST by Alexey Proskuryakov
Modified: 2009-12-01 12:59 PST (History)
4 users (show)

See Also:

Attachments
Disable wss until all platforms support pyOpenSSL (4.15 KB, patch)
2009-11-15 22:03 PST, Yuzo Fujishima 		no flags Details | Formatted Diff | Diff
Disable wss until all platforms support pyOpenSSL (4.15 KB, patch)
2009-11-15 22:12 PST, Yuzo Fujishima 		no flags Details | Formatted Diff | Diff
Fix WebSockets tests on Windows (1.33 KB, patch)
2009-12-01 12:56 PST, Adam Roben (:aroben) 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-11-13 11:28:20 PST 
The server won't start on BuildBot: <http://build.webkit.org/builders/Windows%20Debug%20%28Tests%29/builds/6566/steps/layout-test/logs/stdio>.

I couldn't try this locally, as DRT fails to build for me for some reason.
Comment 1 Yuzo Fujishima 2009-11-15 22:03:47 PST 
Created attachment 43263 [details]
Disable wss until all platforms support pyOpenSSL
Comment 2 Yuzo Fujishima 2009-11-15 22:07:41 PST 
Please review the patch attached.

The Web Socket server cannot be run for wss on Windows because pyOpenSSL is not available there yet.

I chose to disable wss because there are currently no tests for it.

Yuzo
Comment 3 Yuzo Fujishima 2009-11-15 22:12:22 PST 
Created attachment 43264 [details]
Disable wss until all platforms support pyOpenSSL
Comment 4 Alexey Proskuryakov 2009-11-16 10:10:19 PST 
Comment on attachment 43264 [details]
Disable wss until all platforms support pyOpenSSL

I tested that the patch helps on Mac OS X 10.4 (Tiger). I cannot easily test on Windows.

We don't usually keep commented out code - if necessary, it can be restored from Subversion history. Do you have a plan how to enable it soon?

r=me, as we need to get the tests running, but please consider my comment.
Comment 5 Alexey Proskuryakov 2009-11-16 10:11:08 PST 
*** Bug 31501 has been marked as a duplicate of this bug. ***
Comment 6 Alexey Proskuryakov 2009-11-16 10:40:43 PST 
Committed revision 51041, re-enabling tests at the same time. Commit queue doesn't work now.
Comment 7 Alexey Proskuryakov 2009-11-16 15:19:19 PST 
Still times out on buildbot: <http://build.webkit.org/builders/Windows%20Release%20%28Tests%29/builds/6228/steps/layout-test/logs/stdio>.
Comment 8 Alexey Proskuryakov 2009-12-01 12:55:30 PST 
It looks like the server starts now, but tests still don't work, because they are broken by previous scripts (from userscripts directory). Adam Roben is looking into the userscripts problem, and once that's fixed, we might be all set.
Comment 9 Adam Roben (:aroben) 2009-12-01 12:56:36 PST 
Created attachment 44095 [details]
Fix WebSockets tests on Windows
Comment 10 Alexey Proskuryakov 2009-12-01 12:57:34 PST 
Comment on attachment 44095 [details]
Fix WebSockets tests on Windows

r=me
Comment 11 Adam Roben (:aroben) 2009-12-01 12:59:42 PST 
Committed r51554: <http://trac.webkit.org/changeset/51554>