Bug 33212 - Small fixes/improvements to WebKitAPITest
Summary: Small fixes/improvements to WebKitAPITest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-05 09:24 PST by Adam Roben (:aroben)
Modified: 2010-01-05 10:17 PST (History)
1 user (show)

See Also:


Attachments
Fix WebKitCreateInstance helper (1.25 KB, patch)
2010-01-05 09:31 PST, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff
Don't hang in WebKitAPITest if no messages have been posted (1.48 KB, patch)
2010-01-05 09:31 PST, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff
Don't show HostWindows by default (1.53 KB, patch)
2010-01-05 09:31 PST, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff
Share more code in the WebViewDestruction tests (5.91 KB, patch)
2010-01-05 09:39 PST, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-01-05 09:24:04 PST
I have a few small improvements/fixes to WebKitAPITest I'd like to land.
Comment 1 Adam Roben (:aroben) 2010-01-05 09:31:14 PST
Created attachment 45897 [details]
Fix WebKitCreateInstance helper
Comment 2 Adam Roben (:aroben) 2010-01-05 09:31:21 PST
Created attachment 45898 [details]
Don't hang in WebKitAPITest if no messages have been posted
Comment 3 Adam Roben (:aroben) 2010-01-05 09:31:26 PST
Created attachment 45899 [details]
Don't show HostWindows by default
Comment 4 WebKit Review Bot 2010-01-05 09:35:03 PST
style-queue ran check-webkit-style on attachment 45897 [details] without any errors.
Comment 5 WebKit Review Bot 2010-01-05 09:35:33 PST
style-queue ran check-webkit-style on attachment 45898 [details] without any errors.
Comment 6 WebKit Review Bot 2010-01-05 09:36:05 PST
style-queue ran check-webkit-style on attachment 45899 [details] without any errors.
Comment 7 Adam Roben (:aroben) 2010-01-05 09:39:52 PST
Created attachment 45901 [details]
Share more code in the WebViewDestruction tests
Comment 8 WebKit Review Bot 2010-01-05 09:41:37 PST
style-queue ran check-webkit-style on attachment 45901 [details] without any errors.
Comment 9 Adam Roben (:aroben) 2010-01-05 10:16:08 PST
Committed r52802: <http://trac.webkit.org/changeset/52802>
Comment 10 Adam Roben (:aroben) 2010-01-05 10:16:32 PST
Committed r52803: <http://trac.webkit.org/changeset/52803>
Comment 11 Adam Roben (:aroben) 2010-01-05 10:16:59 PST
Committed r52804: <http://trac.webkit.org/changeset/52804>
Comment 12 Adam Roben (:aroben) 2010-01-05 10:17:23 PST
Committed r52805: <http://trac.webkit.org/changeset/52805>