Bug 35918 - [EFL] Add EditorClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
Summary: [EFL] Add EditorClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 06:26 PST by Leandro Pereira
Modified: 2010-04-15 13:18 PDT (History)
11 users (show)

See Also:

Attachments
Add EditorClientEfl to WK/efl/WebCoreSupport. (20.55 KB, patch)
2010-03-09 06:27 PST, Leandro Pereira 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-03-09 06:26:58 PST 
+++ This bug was initially created as a clone of Bug #35059 +++

Attached patch adds EFL's implementation of EditorClientEfl to
WebKit/efl/WebCoreSupport.
Comment 1 Leandro Pereira 2010-03-09 06:27:38 PST 
Created attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.
Comment 2 Holger Freyther 2010-03-14 19:00:03 PDT 
It would be nice if you could share this table with the Gtk+ port somehow. Or at least create a follow up patch patching both Gtk and Efl to mention the others copy of the table and that they need to be kept in sync.... It would be preferable to not have that duplication.
Comment 3 Leandro Pereira 2010-03-31 08:02:13 PDT 
(In reply to comment #2)
> It would be nice if you could share this table with the Gtk+ port somehow. Or
> at least create a follow up patch patching both Gtk and Efl to mention the
> others copy of the table and that they need to be kept in sync.... It would be
> preferable to not have that duplication.

There's a copy of this table in other ports, too (at least with this same name): Wx and Chromium. Do you have any ideas on how this table could be shared amongst all ports that use it, besides having a comment to keep them in sync?
Comment 4 Kenneth Rohde Christiansen 2010-04-15 12:04:07 PDT 
Comment on attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.

LGTM
Comment 5 WebKit Commit Bot 2010-04-15 13:18:09 PDT 
Comment on attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.

Clearing flags on attachment: 50301

Committed r57665: <http://trac.webkit.org/changeset/57665>
Comment 6 WebKit Commit Bot 2010-04-15 13:18:15 PDT 
All reviewed patches have been landed.  Closing bug.