Bug 36431 - Clean up 'int' use in UString.cpp after r54789
Summary: Clean up 'int' use in UString.cpp after r54789
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 34952
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-21 16:12 PDT by David Kilzer (:ddkilzer)
Modified: 2010-03-22 10:40 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2010-03-21 16:12 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (3.64 KB, patch)
2010-03-21 16:17 PDT, David Kilzer (:ddkilzer)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-03-21 16:12:58 PDT
Created attachment 51258 [details]
Patch

Reviewed by NOBODY (OOPS!).

* runtime/UString.cpp:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.
---
 2 files changed, 19 insertions(+), 6 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2010-03-21 16:17:23 PDT
Created attachment 51259 [details]
Patch v2
Comment 2 David Kilzer (:ddkilzer) 2010-03-22 10:40:22 PDT
Committed r56342: <http://trac.webkit.org/changeset/56342>