WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36431
Clean up 'int' use in UString.cpp after
r54789
https://bugs.webkit.org/show_bug.cgi?id=36431
Summary
Clean up 'int' use in UString.cpp after r54789
David Kilzer (:ddkilzer)
Reported
2010-03-21 16:12:58 PDT
Created
attachment 51258
[details]
Patch Reviewed by NOBODY (OOPS!). * runtime/UString.cpp: (JSC::UString::from): Changed argument type from 'unsigned int' to 'unsigned' to match WebKit coding style. (JSC::UString::find): Changed static_cast<int>() to static_cast<unsigned>() now that this method returns unsigned. (JSC::UString::rfind): Ditto. --- 2 files changed, 19 insertions(+), 6 deletions(-)
Attachments
Patch
(3.01 KB, patch)
2010-03-21 16:12 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
Patch v2
(3.64 KB, patch)
2010-03-21 16:17 PDT
,
David Kilzer (:ddkilzer)
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2010-03-21 16:17:23 PDT
Created
attachment 51259
[details]
Patch v2
David Kilzer (:ddkilzer)
Comment 2
2010-03-22 10:40:22 PDT
Committed
r56342
: <
http://trac.webkit.org/changeset/56342
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug