Bug 37354 - Expose UserContentURLPattern as WebKit SPI
Summary: Expose UserContentURLPattern as WebKit SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-04-09 13:31 PDT by Adam Roben (:aroben)
Modified: 2010-04-15 15:20 PDT (History)
2 users (show)

See Also:


Attachments
Expose UserContentURLPattern as WebKit SPI (25.89 KB, patch)
2010-04-15 14:09 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Revised patch with isValid (26.59 KB, patch)
2010-04-15 14:37 PDT, Adam Roben (:aroben)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-04-09 13:31:32 PDT
We'd like to expose UserContentURLPattern as WebKit SPI.
Comment 1 Adam Roben (:aroben) 2010-04-09 13:32:15 PDT
<rdar://problem/7847210>
Comment 2 Adam Roben (:aroben) 2010-04-15 14:09:12 PDT
Created attachment 53475 [details]
Expose UserContentURLPattern as WebKit SPI
Comment 3 WebKit Review Bot 2010-04-15 14:12:52 PDT
Attachment 53475 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebUserContentURLPattern.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit/win/WebUserContentURLPattern.cpp:26:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/win/WebUserContentURLPattern.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2010-04-15 14:18:36 PDT
(In reply to comment #3)
> Attachment 53475 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKit/win/WebUserContentURLPattern.h:32:  Code inside a namespace should not
> be indented.  [whitespace/indent] [4]

This is bug 36760.

> WebKit/win/WebUserContentURLPattern.cpp:26:  Found other header before a header
> this file implements. Should be: config.h, primary header, blank line, and then
> alphabetically sorted.  [build/include_order] [4]
> WebKit/win/WebUserContentURLPattern.cpp:27:  Found header this file implements
> after other header. Should be: config.h, primary header, blank line, and then
> alphabetically sorted.  [build/include_order] [4]

This is bug 37673.
Comment 5 Timothy Hatcher 2010-04-15 14:25:41 PDT
Comment on attachment 53475 [details]
Expose UserContentURLPattern as WebKit SPI

Looks fine. But isValid() needs to be exposed.
Comment 6 Adam Roben (:aroben) 2010-04-15 14:37:34 PDT
Created attachment 53479 [details]
Revised patch with isValid
Comment 7 WebKit Review Bot 2010-04-15 14:41:02 PDT
Attachment 53479 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebUserContentURLPattern.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit/win/WebUserContentURLPattern.cpp:26:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/win/WebUserContentURLPattern.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Adam Roben (:aroben) 2010-04-15 15:20:48 PDT
Committed r57680: <http://trac.webkit.org/changeset/57680>