We'd like to expose UserContentURLPattern as WebKit SPI.
<rdar://problem/7847210>
Created attachment 53475 [details] Expose UserContentURLPattern as WebKit SPI
Attachment 53475 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 53475 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not > be indented. [whitespace/indent] [4] This is bug 36760. > WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header > this file implements. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] > WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements > after other header. Should be: config.h, primary header, blank line, and then > alphabetically sorted. [build/include_order] [4] This is bug 37673.
Comment on attachment 53475 [details] Expose UserContentURLPattern as WebKit SPI Looks fine. But isValid() needs to be exposed.
Created attachment 53479 [details] Revised patch with isValid
Attachment 53479 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/win/WebUserContentURLPattern.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit/win/WebUserContentURLPattern.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/win/WebUserContentURLPattern.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r57680: <http://trac.webkit.org/changeset/57680>