Bug 37809 - REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Summary: REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 10:41 PDT by Adam Roben (:aroben)
Modified: 2010-04-19 12:39 PDT (History)
0 users

See Also:

Attachments
Patch (1.05 KB, patch)
2010-04-19 10:42 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Fix run-webkit-tests when there are spaces in the path (1.20 KB, patch)
2010-04-19 11:32 PDT, Adam Roben (:aroben) 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-04-19 10:41:34 PDT 
REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Comment 1 Adam Roben (:aroben) 2010-04-19 10:42:50 PDT 
Created attachment 53690 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-04-19 11:21:17 PDT 
Comment on attachment 53690 [details]
Patch

I'm going to put up a new patch that explains what's going on here better.
Comment 3 Adam Roben (:aroben) 2010-04-19 11:32:56 PDT 
Created attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path
Comment 4 Adam Barth 2010-04-19 11:34:27 PDT 
Comment on attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path

Ok.  Perl is insane.
Comment 5 Eric Seidel (no email) 2010-04-19 12:21:24 PDT 
Comment on attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path

Sorry for the break.

I'm not sure I understand.  How does this flatten the @ARGV array into the args passed to exec?
Comment 6 Adam Roben (:aroben) 2010-04-19 12:28:45 PDT 
Committed r57825: <http://trac.webkit.org/changeset/57825>
Comment 7 Adam Roben (:aroben) 2010-04-19 12:39:48 PDT 
(In reply to comment #5)
> (From update of attachment 53694 [details])
> I'm not sure I understand.  How does this flatten the @ARGV array into the args
> passed to exec?

Perl does that automagically for you.

$ perl -e 'my @foo = ("1", "2", "3"); my @bar = (@foo, "4", "5", "6"); print scalar(@bar), "\n"'
6

Scary, eh?