Bug 37854 - Add missing EFL port files
Summary: Add missing EFL port files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-20 06:30 PDT by Gustavo Sverzut Barbieri
Modified: 2010-04-22 05:09 PDT (History)
1 user (show)

See Also:


Attachments
Add missing EFL JavaScriptCore (3.09 KB, patch)
2010-04-20 06:42 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
Add missing EFL WebCore (2.90 KB, patch)
2010-04-20 06:42 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
Add missing EFL WebKit/efl (63.50 KB, patch)
2010-04-20 06:44 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
Add missing EFL WebCore (without Plugins) (3.00 KB, patch)
2010-04-20 09:48 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff
EFL disable FrameLoader PluginDatabase usage (1.33 KB, patch)
2010-04-20 10:00 PDT, Gustavo Sverzut Barbieri
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Sverzut Barbieri 2010-04-20 06:30:31 PDT
Due landing of EFL port but are required to have the port to work fine (we forgot to send them before):

 * JavaScriptCore/wtf/efl/MainThreadEfl.cpp
 * WebCore/bindings/js/ScriptControllerEfl.cpp
 * WebKit/efl/DefaultTheme/: edc theme files.

The edc theme files may not seem clear to the non-EFL developer, but they are required otherwise it won't work. EFL does not have the concept of a button, entry and so on, these are defined as theme parts in EDC files. These are the default look and feel, but of course application developers can override them per-view or per-frame, as they wish.
Comment 1 Gustavo Sverzut Barbieri 2010-04-20 06:42:14 PDT
Created attachment 53809 [details]
Add missing EFL JavaScriptCore

Missing file in JavaScriptCore.
Comment 2 Gustavo Sverzut Barbieri 2010-04-20 06:42:58 PDT
Created attachment 53810 [details]
Add missing EFL WebCore

Add missing file to WebCore
Comment 3 Gustavo Sverzut Barbieri 2010-04-20 06:44:05 PDT
Created attachment 53811 [details]
Add missing EFL WebKit/efl

Add missing theme files to WebKit/efl/DefaultTheme. They are required otherwise user will see no button, checkbox, radio buttons and so on.
Comment 4 Nikolas Zimmermann 2010-04-20 06:53:41 PDT
Comment on attachment 53810 [details]
Add missing EFL WebCore

LGTM, r=me.
Comment 5 Nikolas Zimmermann 2010-04-20 06:54:48 PDT
Comment on attachment 53811 [details]
Add missing EFL WebKit/efl

LGTM, r=me.
Comment 6 Nikolas Zimmermann 2010-04-20 06:55:23 PDT
Comment on attachment 53809 [details]
Add missing EFL JavaScriptCore

LGTM, r=me.
Comment 7 Gustavo Sverzut Barbieri 2010-04-20 09:48:19 PDT
Created attachment 53829 [details]
Add missing EFL WebCore (without Plugins)

This new version removes plugins calls so we can compile EFL port with Plugin*None.cpp
Comment 8 Gustavo Sverzut Barbieri 2010-04-20 09:49:01 PDT
Comment on attachment 53810 [details]
Add missing EFL WebCore

Clear flags as it is obsolete.
Comment 9 Adam Roben (:aroben) 2010-04-20 09:52:32 PDT
Comment on attachment 53829 [details]
Add missing EFL WebCore (without Plugins)

r=me
Comment 10 Gustavo Sverzut Barbieri 2010-04-20 10:00:10 PDT
Created attachment 53831 [details]
EFL disable FrameLoader PluginDatabase usage

EFL does not support Plugins and PluginDatabase is not available.
Comment 11 Adam Roben (:aroben) 2010-04-20 10:01:58 PDT
Comment on attachment 53831 [details]
EFL disable FrameLoader PluginDatabase usage

r=me
Comment 12 WebKit Commit Bot 2010-04-21 05:11:46 PDT
Comment on attachment 53809 [details]
Add missing EFL JavaScriptCore

Clearing flags on attachment: 53809

Committed r57968: <http://trac.webkit.org/changeset/57968>
Comment 13 WebKit Commit Bot 2010-04-21 18:04:00 PDT
Comment on attachment 53811 [details]
Add missing EFL WebKit/efl

Clearing flags on attachment: 53811

Committed r58034: <http://trac.webkit.org/changeset/58034>
Comment 14 WebKit Commit Bot 2010-04-21 22:40:02 PDT
Comment on attachment 53829 [details]
Add missing EFL WebCore (without Plugins)

Clearing flags on attachment: 53829

Committed r58053: <http://trac.webkit.org/changeset/58053>
Comment 15 WebKit Commit Bot 2010-04-22 05:09:44 PDT
Comment on attachment 53831 [details]
EFL disable FrameLoader PluginDatabase usage

Clearing flags on attachment: 53831

Committed r58089: <http://trac.webkit.org/changeset/58089>
Comment 16 WebKit Commit Bot 2010-04-22 05:09:49 PDT
All reviewed patches have been landed.  Closing bug.