Bug 38768 - SunSpider computes incorrect two-sample t statistics
Summary: SunSpider computes incorrect two-sample t statistics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 12:49 PDT by Adam Roben (:aroben)
Modified: 2010-05-13 10:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2010-05-07 12:52 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-05-07 12:49:48 PDT
SunSpider computes incorrect two-sample t statistics
Comment 1 Adam Roben (:aroben) 2010-05-07 12:52:50 PDT
Created attachment 55410 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-08 23:16:58 PDT
Attachment 55410 [details] was posted by a committer and has review+, assigning to Adam Roben for commit.
Comment 3 Adam Roben (:aroben) 2010-05-10 06:32:23 PDT
I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs.
Comment 4 Adam Roben (:aroben) 2010-05-10 07:13:03 PDT
(In reply to comment #3)
> I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs.

In fact, my patch doesn't change the versions of SunSpider hosted on webkit.org, so this is definitely not necessary at the moment.

I wonder if we should change those versions, though?
Comment 5 Adam Roben (:aroben) 2010-05-13 10:12:05 PDT
Committed r59370: <http://trac.webkit.org/changeset/59370>
Comment 6 Adam Roben (:aroben) 2010-05-13 10:18:46 PDT
Maciej, do you think we should apply this change to the public versions of SunSpider?