Bug 38849 - REGRESSION (r59016): plugins/set-status.html fails on Windows
Summary: REGRESSION (r59016): plugins/set-status.html fails on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 09:05 PDT by Adam Roben (:aroben)
Modified: 2010-05-13 10:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2010-05-10 09:09 PDT, Adam Roben (:aroben)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-05-10 09:05:55 PDT
REGRESSION (r59016): plugins/set-status.html fails on Windows
Comment 1 Adam Roben (:aroben) 2010-05-10 09:09:35 PDT
Created attachment 55558 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-05-10 10:12:24 PDT
Comment on attachment 55558 [details]
Patch

r=me, because this DRT-only fix can't be wrong, but I don't understand what happened here. Why did %S truncate the text, isn't it supposed to work for UTF-16?

For double safety you may want to check what happens in Safari - is the status text set to what we expect it to?
Comment 3 Adam Roben (:aroben) 2010-05-13 09:21:25 PDT
(In reply to comment #2)
> (From update of attachment 55558 [details])
> r=me, because this DRT-only fix can't be wrong, but I don't understand what happened here. Why did %S truncate the text, isn't it supposed to work for UTF-16?

I did a little more debugging. %S does "work" for UTF-16. But it converts the input string to a non-wide string using wctomb, which uses the codepage for the current locale. The conversion is failing, which causes printf to bail. I'll add this information to the ChangeLog.

> For double safety you may want to check what happens in Safari - is the status text set to what we expect it to?

Yes, Safari works as expected.

Thanks for the review!
Comment 4 Adam Roben (:aroben) 2010-05-13 10:10:56 PDT
Committed r59371: <http://trac.webkit.org/changeset/59371>