Bug 39899 - [EFL] Allow building of shared core libraries
Summary: [EFL] Allow building of shared core libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 14:00 PDT by Leandro Pereira
Modified: 2010-06-09 13:31 PDT (History)
3 users (show)

See Also:


Attachments
Allow building of shared core libraries (9.11 KB, patch)
2010-05-28 14:01 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff
[EFL] Allow building of shared core libraries (9.11 KB, patch)
2010-06-02 11:17 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff
[EFL] Allow building of shared core libraries (8.66 KB, patch)
2010-06-07 08:31 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff
Allow building of shared core libraries (8.67 KB, patch)
2010-06-07 11:11 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-05-28 14:00:06 PDT
To speed up linking times in machines with a small amount of memory, one can use the attached patch to allow linking the core libraries as shared objects. This of course impacts load time, and should only be used when making changes to WebCore/WebCoreSupport.
Comment 1 Leandro Pereira 2010-05-28 14:01:38 PDT
Created attachment 57374 [details]
 Allow building of shared core libraries
Comment 2 Adam Treat 2010-06-02 11:10:54 PDT
Comment on attachment 57374 [details]
 Allow building of shared core libraries

The changes where you add files please put this in another patch in the future. Thanks!
Comment 3 Leandro Pereira 2010-06-02 11:17:44 PDT
Created attachment 57669 [details]
[EFL] Allow building of shared core libraries

Same patch, without unrelated changes that managed to slip in.
Comment 4 Leandro Pereira 2010-06-07 08:31:55 PDT
Created attachment 58032 [details]
[EFL] Allow building of shared core libraries

This patch was already reviewed by manyoso; uploading it again with his name on the reviewer line.
Comment 5 WebKit Commit Bot 2010-06-07 08:32:44 PDT
Comment on attachment 58032 [details]
[EFL] Allow building of shared core libraries

Rejecting patch 58032 from review queue.

leandro@profusion.mobi does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Commit Bot 2010-06-07 08:35:26 PDT
Comment on attachment 58032 [details]
[EFL] Allow building of shared core libraries

Rejecting patch 58032 from commit-queue.

leandro@profusion.mobi does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 Eric Seidel (no email) 2010-06-07 09:40:35 PDT
Comment on attachment 57374 [details]
 Allow building of shared core libraries

Cleared Adam Treat's review+ from obsolete attachment 57374 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 8 Leandro Pereira 2010-06-07 11:11:29 PDT
Created attachment 58048 [details]
Allow building of shared core libraries

Resending the patch, to reset the flags. (Turns out the bots aren't so smart. :))
Comment 9 WebKit Commit Bot 2010-06-09 13:31:48 PDT
Comment on attachment 58048 [details]
Allow building of shared core libraries

Clearing flags on attachment: 58048

Committed r60909: <http://trac.webkit.org/changeset/60909>
Comment 10 WebKit Commit Bot 2010-06-09 13:31:54 PDT
All reviewed patches have been landed.  Closing bug.