Bug 40331 - [EFL] Build fix for SVN r60860
Summary: [EFL] Build fix for SVN r60860
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 14:01 PDT by Leandro Pereira
Modified: 2010-06-11 12:00 PDT (History)
2 users (show)

See Also:


Attachments
Build fix for SVN r60860 (2.48 KB, patch)
2010-06-08 14:02 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff
Build fix for SVN r60860 (2.27 KB, patch)
2010-06-10 10:57 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-06-08 14:01:29 PDT
EFL port fails to build on SVN r60860. Attached patch fixed that.
Comment 1 Leandro Pereira 2010-06-08 14:02:06 PDT
Created attachment 58177 [details]
Build fix for SVN r60860
Comment 2 Kent Tamura 2010-06-08 20:41:09 PDT
Comment on attachment 58177 [details]
Build fix for SVN r60860

Looks OK.
Comment 3 WebKit Commit Bot 2010-06-09 22:25:04 PDT
Comment on attachment 58177 [details]
Build fix for SVN r60860

Rejecting patch 58177 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/CMakeLists.txt
Hunk #1 succeeded at 1097 (offset 1 line).
Hunk #2 succeeded at 1134 (offset 1 line).
Hunk #3 FAILED at 1262.
1 out of 4 hunks FAILED -- saving rejects to file WebCore/CMakeLists.txt.rej
patching file WebCore/CMakeListsEfl.txt
Hunk #1 succeeded at 15 (offset 5 lines).
Hunk #2 succeeded at 83 (offset 5 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3258024
Comment 4 Leandro Pereira 2010-06-10 10:57:13 PDT
Created attachment 58391 [details]
Build fix for SVN r60860

Updating patch to a recent revision.
Comment 5 Leandro Pereira 2010-06-10 10:57:52 PDT
Comment on attachment 58177 [details]
Build fix for SVN r60860

Clearing flags from obsolete patch.
Comment 6 WebKit Commit Bot 2010-06-11 12:00:21 PDT
Comment on attachment 58391 [details]
Build fix for SVN r60860

Clearing flags on attachment: 58391

Committed r61030: <http://trac.webkit.org/changeset/61030>
Comment 7 WebKit Commit Bot 2010-06-11 12:00:25 PDT
All reviewed patches have been landed.  Closing bug.