Bug 43047 - WebKitTestRunner waits forever if the web process crashes
Summary: WebKitTestRunner waits forever if the web process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 43048
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-27 07:39 PDT by Adam Roben (:aroben)
Modified: 2010-11-03 13:54 PDT (History)
2 users (show)

See Also:


Attachments
Stop waiting for messages from the web process after a timeout elapses (9.72 KB, patch)
2010-11-03 12:55 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Updated to make timeouts configurable (14.06 KB, patch)
2010-11-03 13:47 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-07-27 07:39:44 PDT
If the web process crashes while running a test, WebKitTestRunner waits forever. We should detect when the process crashes, print some failure message, and move on to the next test.
Comment 1 Adam Roben (:aroben) 2010-07-27 07:42:18 PDT
<rdar://problem/8239456>
Comment 2 Adam Roben (:aroben) 2010-08-17 06:48:31 PDT
The hang seems not to happen anymore, perhaps due to r65267.
Comment 3 Adam Roben (:aroben) 2010-08-27 13:48:43 PDT
Turns out this can still happen. One way I can make it reproduce:

1. Set a breakpoint in TestInvocation::invoke just before WKContextPostMessageToInjectedBundle is called
2. When the breakpoint is hit, kill the web process
Comment 4 Adam Roben (:aroben) 2010-08-27 13:49:13 PDT
Reopening due to the above.
Comment 5 Adam Roben (:aroben) 2010-11-03 12:55:18 PDT
Created attachment 72852 [details]
Stop waiting for messages from the web process after a timeout elapses
Comment 6 Adam Roben (:aroben) 2010-11-03 13:47:48 PDT
Created attachment 72865 [details]
Updated to make timeouts configurable
Comment 7 Adam Roben (:aroben) 2010-11-03 13:54:01 PDT
Committed r71263: <http://trac.webkit.org/changeset/71263>