Bug 46913 - REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
Summary: REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when runni...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2010-09-30 09:50 PDT by Adam Roben (:aroben)
Modified: 2010-09-30 17:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch for this and bug 46914. (4.31 KB, patch)
2010-09-30 16:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2010-09-30 16:52 PDT, Simon Fraser (smfr) 		jhoneycutt: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-09-30 09:50:48 PDT 
The buildbots are crashing when running platform/win/accessibility/selection-and-focus.html. Looks like a null-dereference. See the URL for the crash log.
Comment 1 Adam Roben (:aroben) 2010-09-30 09:51:42 PDT 
<rdar://problem/8497332>
Comment 2 Adam Roben (:aroben) 2010-09-30 09:56:39 PDT 
webkit-patch failure-reason blames http://trac.webkit.org/changeset/65681
Comment 3 Simon Fraser (smfr) 2010-09-30 15:45:21 PDT 
For some reason,  accessibilityController.focusedElement.childAtIndex(0).takeFocus();
is now focussing the anonymous block that is the select's parent.
Comment 4 Simon Fraser (smfr) 2010-09-30 16:10:07 PDT 
I think the test is incorrect. I don't know how it passed before.
Comment 5 Simon Fraser (smfr) 2010-09-30 16:37:39 PDT 
Created attachment 69392 [details]
Patch for this and bug 46914.
Comment 6 WebKit Review Bot 2010-09-30 16:43:17 PDT 
Attachment 69392 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Simon Fraser (smfr) 2010-09-30 16:52:51 PDT 
Created attachment 69396 [details]
Patch
Comment 8 Jon Honeycutt 2010-09-30 16:59:43 PDT 
Comment on attachment 69396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69396&action=review

> LayoutTests/platform/win/accessibility/selection-and-focus.html:42
> +        

Reduce whitespace! Save the whitespace trees!
Comment 9 Simon Fraser (smfr) 2010-09-30 17:40:09 PDT 
http://trac.webkit.org/changeset/68855