Bug 47049 - [Qt] Can't build jsc (stand-alone JS interpreter)
Summary: [Qt] Can't build jsc (stand-alone JS interpreter)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-02 08:32 PDT by Ariya Hidayat
Modified: 2010-10-05 12:01 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-10-02 08:32:56 PDT 
jsc, the JS shell, can't be built because jsc.pro specifies the TARGET=jsc and there exists already a subdirectory called jsc/, for CMake build files.

Possible solutions:

(1) we rename the TARGET to e.g. jsc-shell

(2) we rename jsc/ to e.g. shell/

I lean towards (2). AFAICS it's only for CMakeLists.txt so we should be more flexible there and does not break other ports.

Comments?
Comment 1 Kenneth Rohde Christiansen 2010-10-02 08:37:38 PDT 
2) is fine with me.
Comment 2 Ariya Hidayat 2010-10-02 08:39:37 PDT 
(In reply to comment #1)
> 2) is fine with me.

Can someone handle this? I don't have EFL ready to test such a change.
Comment 3 Antonio Gomes 2010-10-02 17:26:03 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > 2) is fine with me.
> 
> Can someone handle this? I don't have EFL ready to test such a change.

Leandro, could you please help or ask one of the your guys? :-)
Comment 4 Leandro Pereira 2010-10-05 12:01:43 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > 2) is fine with me.
> > 
> > Can someone handle this? I don't have EFL ready to test such a change.
> 
> Leandro, could you please help or ask one of the your guys? :-)

Moved it. Should be on r69132. I'm closing this bug.