Bug 47270 - Move WebArchive serialization code into its own file
Summary: Move WebArchive serialization code into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 09:02 PDT by David Kilzer (:ddkilzer)
Modified: 2010-10-06 09:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (115.53 KB, patch)
2010-10-06 09:03 PDT, David Kilzer (:ddkilzer) 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-10-06 09:02:58 PDT 
Move WebArchive serialization code into its own file
Comment 1 David Kilzer (:ddkilzer) 2010-10-06 09:03:53 PDT 
Created attachment 69947 [details]
Patch v1

Move WebArchive serialization code into its own file
Comment 2 David Kilzer (:ddkilzer) 2010-10-06 09:06:31 PDT 
Comment on attachment 69947 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=69947&action=review

> WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:704
> +			developmentRegion = English;
>  			hasScannedForEncodings = 1;
> +			knownRegions = (
> +				English,
> +				Japanese,
> +				French,
> +				German,
> +			);

I'll remove this before landing.

Note that this patch is so big because I used "svn cp" to create DumpRenderTreeWebArchive.mm from DumpRenderTree.mm.
Comment 3 Adam Roben (:aroben) 2010-10-06 09:13:35 PDT 
Comment on attachment 69947 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=69947&action=review

> WebKitTools/ChangeLog:15
> +        * DumpRenderTree/mac/DumpRenderTreeWebArchive.h: Added.
> +        * DumpRenderTree/mac/DumpRenderTreeWebArchive.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.

Maybe these should be called WebArchiveDumpSupport.h/mm? That would match PixelDumpSupport, which we already have.
Comment 4 David Kilzer (:ddkilzer) 2010-10-06 09:33:40 PDT 
(In reply to comment #3)
> (From update of attachment 69947 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69947&action=review
> 
> > WebKitTools/ChangeLog:15
> > +        * DumpRenderTree/mac/DumpRenderTreeWebArchive.h: Added.
> > +        * DumpRenderTree/mac/DumpRenderTreeWebArchive.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
> 
> Maybe these should be called WebArchiveDumpSupport.h/mm? That would match
> PixelDumpSupport, which we already have.

I will make this change before landing.  Thanks!
Comment 5 David Kilzer (:ddkilzer) 2010-10-06 09:36:24 PDT 
Committed r69199: <http://trac.webkit.org/changeset/69199>
Comment 6 David Kilzer (:ddkilzer) 2010-10-06 09:36:53 PDT 
(In reply to comment #5)
> Committed r69199: <http://trac.webkit.org/changeset/69199>

Embarrassing ChangeLog fix in r69200:  <http://trac.webkit.org/changeset/69200>