This feature is missing. ( revealed by https://bugs.webkit.org/show_bug.cgi?id=48185 ) Yael, could you fix it? Please make sure not to break any port with this new default value.
(In reply to comment #0) > This feature is missing. ( revealed by https://bugs.webkit.org/show_bug.cgi?id=48185 ) > > Yael, could you fix it? Please make sure not to > break any port with this new default value. Do all ports have this enabled by default, or only some?
(In reply to comment #1) > Do all ports have this enabled by default, or only some? It looks like GTK disables it in WebCore/GNUmakefile.am, but Qt, Chrome and Apple (Mac) have it enabled.
Created attachment 71740 [details] Patch v1 Let the EWS bots check this.
Comment on attachment 71740 [details] Patch v1 All EWS' are green, except Win-EWS. (It is stucked.) I checked build systems, but it seems that meter tag is disabled on Windows too, because it is missing from FeatureDefines.vsprops. Otherwise LGTM, r=me if you set correct default value for Windows.
I'm going to file a new bug to fix FeatureDefines.vsprops .
(In reply to comment #4) > (From update of attachment 71740 [details]) > All EWS' are green, except Win-EWS. (It is stucked.) > > I checked build systems, but it seems that meter tag > is disabled on Windows too, because it is missing from > FeatureDefines.vsprops. Otherwise LGTM, r=me if you set > correct default value for Windows. Okay. Which ports use the vcproj files? Or should I use: !isGtk() && !(isWindows() || isCygwin())
(In reply to comment #6) > Which ports use the vcproj files? Apple's Windows port, the Cairo/CFLite/libcurl Windows port, and the WinCE port (I think).
> !isGtk() && !(isWindows() || isCygwin()) maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , because METER_TAG is enabled on Qt, but Qt port has Windows build. But ... it is soooo ugly ...
(In reply to comment #8) > > !isGtk() && !(isWindows() || isCygwin()) > maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , > because METER_TAG is enabled on Qt, but Qt port has Windows build. > > But ... it is soooo ugly ... !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled.
(In reply to comment #9) > !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. OK, I hope we won't break any other ports. :)
(In reply to comment #10) > (In reply to comment #9) > > !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. > > OK, I hope we won't break any other ports. :) The Qt Windows ports build with ENABLE_METER_TAG=1, so Adam's suggestion should work. The only port I'm not sure about is WinCairo because I can't find a recent-ish buildbot log for it.
Committed r70606: <http://trac.webkit.org/changeset/70606>
Comment on attachment 71740 [details] Patch v1 Clearing flags.
For historical completeness, I just wanted to comment that this change should be fine for the WinCairo port.