Bug 48435 - REGRESSION (r70655): Many plugins tests are failing on Qt
Summary: REGRESSION (r70655): Many plugins tests are failing on Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 10:06 PDT by Adam Roben (:aroben)
Modified: 2010-10-27 14:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2010-10-27 10:07 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-27 10:06:50 PDT 
REGRESSION (r70655): Many plugins tests are failing on Qt
Comment 1 Adam Roben (:aroben) 2010-10-27 10:07:31 PDT 
Created attachment 72050 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-27 10:12:50 PDT 
Attachment 72050 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:53:  PluginTest::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:58:  NullNPPGetValuePointer::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-10-27 10:14:07 PDT 
Committed r70662: <http://trac.webkit.org/changeset/70662>
Comment 4 WebKit Review Bot 2010-10-27 14:04:03 PDT 
http://trac.webkit.org/changeset/70662 might have broken GTK Linux 32-bit Debug