Bug 48439 - Web Inspector: Need WebKit2 API for enabling developer extras
Summary: Web Inspector: Need WebKit2 API for enabling developer extras
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 10:36 PDT by Timothy Hatcher
Modified: 2010-11-18 04:46 PST (History)
11 users (show)

See Also:

Attachments
Proposed Change (7.46 KB, patch)
2010-10-27 10:42 PDT, Timothy Hatcher 		sullivan: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-10-27 10:36:22 PDT 
Need WebKit2 API for enabling developer extras.
Comment 1 Timothy Hatcher 2010-10-27 10:42:19 PDT 
Created attachment 72055 [details]
Proposed Change
Comment 2 John Sullivan 2010-10-27 11:09:28 PDT 
Comment on attachment 72055 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=72055&action=review

> WebKit2/Shared/WebPreferencesStore.cpp:48
> +    , developerExtrasEnabled(false)

Maybe we should keep these sorted (I think they started that way, but privateBrowsingEnabled is out of order).

> WebKit2/Shared/WebPreferencesStore.cpp:83
> +    encoder->encode(developerExtrasEnabled);

Same here.

> WebKit2/Shared/WebPreferencesStore.cpp:121
> +        return false;

Same here.
Comment 3 Andreas Kling 2010-11-18 04:46:43 PST 
This was landed in <http://trac.webkit.org/changeset/70680>