Bug 48604 - Functions in WebEvent.h should be moved to .cpp files
Summary: Functions in WebEvent.h should be moved to .cpp files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-28 18:08 PDT by Adam Roben (:aroben)
Modified: 2010-12-14 07:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (38.41 KB, patch)
2010-10-28 18:09 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-28 18:08:32 PDT 
Functions in WebEvent.h should be moved to .cpp files
Comment 1 Adam Roben (:aroben) 2010-10-28 18:09:35 PDT 
Created attachment 72278 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-28 18:12:41 PDT 
Attachment 72278 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/WebTouchEvent.cpp:28:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/WebPlatformTouchPoint.cpp:28:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/WebEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/WebMouseEvent.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/WebWheelEvent.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/WebKeyboardEvent.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-12-14 01:49:59 PST 
I assume this was landed bug not closed?
Comment 4 Adam Roben (:aroben) 2010-12-14 07:45:12 PST 
Landed in r70836.