Bug 48837 - REGRESSION (r71097): Many http tests failing on Windows
Summary: REGRESSION (r71097): Many http tests failing on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2010-11-02 08:23 PDT by Adam Roben (:aroben)
Modified: 2010-11-02 08:38 PDT (History)
1 user (show)

See Also:


Attachments
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on (3.95 KB, patch)
2010-11-02 08:28 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-02 08:23:07 PDT
r71097 [1] changed DRT to record resource identifiers even when dumpResourceLoadCallbacks is turned off. This made Windows diverge from the expected test results by including URLs for the main resource.

1. http://trac.webkit.org/changeset/71097
Comment 1 Adam Roben (:aroben) 2010-11-02 08:25:16 PDT
<rdar://problem/8620351>
Comment 2 Adam Roben (:aroben) 2010-11-02 08:28:20 PDT
Created attachment 72670 [details]
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on
Comment 3 Anders Carlsson 2010-11-02 08:29:24 PDT
Comment on attachment 72670 [details]
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review

> WebKitTools/ChangeLog:59
> +

This seems unrelated?
Comment 4 Adam Roben (:aroben) 2010-11-02 08:29:51 PDT
Comment on attachment 72670 [details]
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review

>> WebKitTools/ChangeLog:59
>> +
> 
> This seems unrelated?

Yes, whoops!
Comment 5 Adam Roben (:aroben) 2010-11-02 08:38:21 PDT
Committed r71116: <http://trac.webkit.org/changeset/71116>