Bug 49028 - It's hard to write a PluginTest with a custom WNDPROC
Summary: It's hard to write a PluginTest with a custom WNDPROC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 14:48 PDT by Adam Roben (:aroben)
Modified: 2010-11-05 07:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.21 KB, patch)
2010-11-04 14:49 PDT, Adam Roben (:aroben)
jhoneycutt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-04 14:48:09 PDT
It's hard to write a PluginTest with a custom WNDPROC
Comment 1 Adam Roben (:aroben) 2010-11-04 14:49:25 PDT
Created attachment 72984 [details]
Patch
Comment 2 WebKit Review Bot 2010-11-04 14:52:15 PDT
Attachment 72984 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:39:  WindowedPluginTest::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:99:  NPNInvalidateRectInvalidatesWindow::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-11-04 15:02:29 PDT
(In reply to comment #2)
> Attachment 72984 [details] did not pass style-queue:
> ...
> If any of these errors are false positives, please file a bug against check-webkit-style.

Filed bug 49030.
Comment 4 Adam Roben (:aroben) 2010-11-05 07:50:27 PDT
Committed r71417: <http://trac.webkit.org/changeset/71417>