It's hard to write a PluginTest with a custom WNDPROC
Created attachment 72984 [details] Patch
Attachment 72984 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:39: WindowedPluginTest::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:99: NPNInvalidateRectInvalidatesWindow::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 72984 [details] did not pass style-queue: > ... > If any of these errors are false positives, please file a bug against check-webkit-style. Filed bug 49030.
Committed r71417: <http://trac.webkit.org/changeset/71417>