Bug 49030 - check-webkit-style is ignorant of TestNetscapePlugIn's coding conventions
Summary: check-webkit-style is ignorant of TestNetscapePlugIn's coding conventions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-04 15:02 PDT by Adam Roben (:aroben)
Modified: 2010-11-05 07:51 PDT (History)
1 user (show)

See Also:

Attachments
Teach check-webkit-style about TestNetscapePlugIn (1.83 KB, patch)
2010-11-04 15:13 PDT, Adam Roben (:aroben) 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-04 15:02:09 PDT 
check-webkit-style is ignorant of TestNetscapePlugIn's coding conventions. See, e.g.., bug 49028 comment 2. We should teach it!
Comment 1 Adam Roben (:aroben) 2010-11-04 15:13:00 PDT 
Created attachment 72988 [details]
Teach check-webkit-style about TestNetscapePlugIn
Comment 2 WebKit Review Bot 2010-11-04 15:16:01 PDT 
Attachment 72988 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/Scripts/webkitpy/style/checker.py']" exit_code: 1
WebKitTools/Scripts/webkitpy/style/checker.py:119:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-11-04 15:16:45 PDT 
(In reply to comment #2)
> Attachment 72988 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/Scripts/webkitpy/style/checker.py']" exit_code: 1
> WebKitTools/Scripts/webkitpy/style/checker.py:119:  at least two spaces before inline comment  [pep8/E261] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

How ironic. I was just following the existing style in this function!
Comment 4 Adam Roben (:aroben) 2010-11-05 07:51:10 PDT 
Committed r71419: <http://trac.webkit.org/changeset/71419>