Bug 49181 - Windows build fails mysteriously when .vsprops files are updated
Summary: Windows build fails mysteriously when .vsprops files are updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 08:46 PST by Adam Roben (:aroben)
Modified: 2010-11-22 13:51 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.88 KB, patch)
2010-11-08 08:49 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files (134.56 KB, patch)
2010-11-22 09:51 PST, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files (139.87 KB, patch)
2010-11-22 10:01 PST, Adam Roben (:aroben)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-08 08:46:30 PST
Windows build fail mysteriously when .vsprops files are updated
Comment 1 Adam Roben (:aroben) 2010-11-08 08:49:07 PST
Created attachment 73243 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-08 08:52:49 PST
Comment on attachment 73243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73243&action=review

> JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd:11
> +set Message=

I've deleted this line locally. It wasn't meant to be left in.
Comment 3 Adam Roben (:aroben) 2010-11-08 09:19:04 PST
Committed r71532: <http://trac.webkit.org/changeset/71532>
Comment 4 Adam Roben (:aroben) 2010-11-08 11:06:13 PST
I rolled out this change in r71545 because it broke the build for people using Cygwin 1.7.
Comment 5 WebKit Review Bot 2010-11-08 11:41:43 PST
http://trac.webkit.org/changeset/71532 might have broken GTK Linux 64-bit Debug
Comment 6 Adam Roben (:aroben) 2010-11-19 17:28:17 PST
I think we could fix this by modifying the react-to-vsprops-changes.py script that JavaScriptCoreGenerated runs to touch wtf/Platform.h whenever it is older than any .vsprops file.
Comment 7 Adam Roben (:aroben) 2010-11-22 08:46:45 PST
I'm working on this. I'm going to make it so we don't have to copy vsprops files at all.
Comment 8 Adam Roben (:aroben) 2010-11-22 09:51:25 PST
Created attachment 74566 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Comment 9 Adam Roben (:aroben) 2010-11-22 10:01:14 PST
Created attachment 74569 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Comment 10 Dave Hyatt 2010-11-22 13:12:47 PST
Comment on attachment 74569 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

r=me
Comment 11 Adam Roben (:aroben) 2010-11-22 13:51:15 PST
Committed r72555: <http://trac.webkit.org/changeset/72555>