Bug 49326 - print-vse-failure-logs prints logs in an unhelpful order
Summary: print-vse-failure-logs prints logs in an unhelpful order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 10:00 PST by Adam Roben (:aroben)
Modified: 2010-11-10 10:36 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2010-11-10 10:04 PST, Adam Roben (:aroben) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-10 10:00:41 PST 
print-vse-failure-logs prints logs in an unhelpful order
Comment 1 Adam Roben (:aroben) 2010-11-10 10:04:49 PST 
Created attachment 73504 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-11-10 10:13:43 PST 
Comment on attachment 73504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73504&action=review

SOOO EXCITED!

We still need to test this stuff.

> WebKitTools/Scripts/print-vse-failure-logs:57
> +    def _build_order(self):

Might be helpful to explain what this returns.

> WebKitTools/Scripts/print-vse-failure-logs:58
> +        script_path = os.path.join(self._scripts_directory(), "print-msvc-project-dependencies")

I didn't know this existed!

> WebKitTools/Scripts/print-vse-failure-logs:76
> +            return (index, project_name)

I didn't realize a tuple could be a sort key.
Comment 3 Adam Roben (:aroben) 2010-11-10 10:23:30 PST 
(In reply to comment #2)
> (From update of attachment 73504 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73504&action=review
> 
> SOOO EXCITED!

Yay!

> We still need to test this stuff.

Filed bug 49327.

> > WebKitTools/Scripts/print-vse-failure-logs:57
> > +    def _build_order(self):
> 
> Might be helpful to explain what this returns.

OK, I'll add a docstring.

> > WebKitTools/Scripts/print-vse-failure-logs:76
> > +            return (index, project_name)
> 
> I didn't realize a tuple could be a sort key.

I didn't either, but I tested it and it does what we want.

Thanks for reviewing!
Comment 4 Adam Roben (:aroben) 2010-11-10 10:36:05 PST 
Committed r71752: <http://trac.webkit.org/changeset/71752>