RESOLVED FIXED 49326
print-vse-failure-logs prints logs in an unhelpful order 
https://bugs.webkit.org/show_bug.cgi?id=49326
Summary print-vse-failure-logs prints logs in an unhelpful order
Adam Roben (:aroben)
Reported 2010-11-10 10:00:41 PST
print-vse-failure-logs prints logs in an unhelpful order
Attachments
Patch (4.31 KB, patch)
2010-11-10 10:04 PST, Adam Roben (:aroben) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-10 10:04:49 PST
Created attachment 73504 [details] Patch
Eric Seidel (no email)
Comment 2 2010-11-10 10:13:43 PST
Comment on attachment 73504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73504&action=review SOOO EXCITED! We still need to test this stuff. > WebKitTools/Scripts/print-vse-failure-logs:57 > + def _build_order(self): Might be helpful to explain what this returns. > WebKitTools/Scripts/print-vse-failure-logs:58 > + script_path = os.path.join(self._scripts_directory(), "print-msvc-project-dependencies") I didn't know this existed! > WebKitTools/Scripts/print-vse-failure-logs:76 > + return (index, project_name) I didn't realize a tuple could be a sort key.
Adam Roben (:aroben)
Comment 3 2010-11-10 10:23:30 PST
(In reply to comment #2) > (From update of attachment 73504 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73504&action=review > > SOOO EXCITED! Yay! > We still need to test this stuff. Filed bug 49327. > > WebKitTools/Scripts/print-vse-failure-logs:57 > > + def _build_order(self): > > Might be helpful to explain what this returns. OK, I'll add a docstring. > > WebKitTools/Scripts/print-vse-failure-logs:76 > > + return (index, project_name) > > I didn't realize a tuple could be a sort key. I didn't either, but I tested it and it does what we want. Thanks for reviewing!
Adam Roben (:aroben)
Comment 4 2010-11-10 10:36:05 PST
Committed r71752: <http://trac.webkit.org/changeset/71752>
Note You need to log in before you can comment on or make changes to this bug.