Bug 49643 - Changes to LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
Summary: Changes to LayoutTests/platform/mac-wk2 should trigger a Windows build, but d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-11-16 22:35 PST by Adam Roben (:aroben)
Modified: 2010-11-17 10:32 PST (History)
3 users (show)

See Also:

Attachments
Make changes to the Mac WebKit2 Skipped file trigger Windows builds (2.52 KB, patch)
2010-11-17 10:11 PST, Adam Roben (:aroben) 		sfalken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-16 22:35:41 PST 
r72167 modified LayoutTests/platform/mac-wk2/Skipped, but it did not trigger a Windows build. Windows uses this file (and the test results in that directory) when running tests using WebKit2, so changes to it should trigger a Windows build.
Comment 1 Adam Roben (:aroben) 2010-11-17 10:11:25 PST 
Created attachment 74130 [details]
Make changes to the Mac WebKit2 Skipped file trigger Windows builds
Comment 2 Adam Roben (:aroben) 2010-11-17 10:14:26 PST 
Committed r72218: <http://trac.webkit.org/changeset/72218>
Comment 3 Adam Roben (:aroben) 2010-11-17 10:15:02 PST 
Bill, this change requires a master restart to take effect. It's not super critical to do it quickly, though.
Comment 4 Eric Seidel (no email) 2010-11-17 10:16:48 PST 
We could have the windows bot make this decision instead of the master to avoid the restart.
Comment 5 Adam Roben (:aroben) 2010-11-17 10:21:39 PST 
(In reply to comment #4)
> We could have the windows bot make this decision instead of the master to avoid the restart.

That's an interesting idea. It might confuse our tools to have a build that doesn't produce anything but isn't a failure, however.
Comment 6 William Siegrist 2010-11-17 10:32:10 PST 
Master restarted.