Bug 50236 - [Qt] Implement layoutTestController.findString
Summary: [Qt] Implement layoutTestController.findString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: LayoutTestFailure, PlatformOnly, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-30 06:52 PST by Adam Roben (:aroben)
Modified: 2011-11-17 10:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2010-11-30 09:35 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-30 06:52:44 PST 
r72887 added layoutTestController.findString and r72889 added the one test that uses it to the Skipped list. We should implement layoutTestController.findString so that we can run that test (and any future tests that are added that use it).
Comment 1 Benjamin Poulain 2010-11-30 09:35:50 PST 
Created attachment 75158 [details]
Patch

Add the missing function.

I don't cq? yet, the test does not pass, all find() call with AtWordStarts fail.
Comment 2 Benjamin Poulain 2010-11-30 10:11:47 PST 
Ok, the test fails when Qt is compiled without ICU (default) because r72887 only implements the feature only for USE(ICU_UNICODE).
Comment 3 Antonio Gomes 2010-11-30 14:05:35 PST 
Comment on attachment 75158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75158&action=review

> WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:461
> +    // 2. find the string

I'd drop (1) and (2) comments here ... they are useless :)
Comment 4 WebKit Commit Bot 2010-11-30 20:19:01 PST 
Comment on attachment 75158 [details]
Patch

Clearing flags on attachment: 75158

Committed r73007: <http://trac.webkit.org/changeset/73007>
Comment 5 WebKit Commit Bot 2010-11-30 20:19:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Martin Kosiba 2011-11-17 10:54:20 PST 
You forgot to uncomment the skipped findString layout test in platform/qt/Skipped:720.