Bug 50238 - WebKitTestRunner needs layoutTestController.findString
Summary: WebKitTestRunner needs layoutTestController.findString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2010-11-30 06:54 PST by Adam Roben (:aroben)
Modified: 2010-12-14 01:30 PST (History)
3 users (show)

See Also:


Attachments
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation (18.79 KB, patch)
2010-11-30 11:06 PST, mitz
no flags Details | Formatted Diff | Diff
Generate bindings for findString (3.34 KB, patch)
2010-12-01 10:29 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-11-30 06:54:25 PST
r72887 added layoutTestController.findString. I'm going to add the one test that needs it to the mac-wk2 Skipped file. We should implement layoutTestController.findString so that we can run that test (and any future tests that are added that use it).
Comment 1 Adam Roben (:aroben) 2010-11-30 06:55:28 PST
<rdar://problem/8710645>
Comment 2 mitz 2010-11-30 11:06:03 PST
Created attachment 75169 [details]
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation
Comment 3 mitz 2010-11-30 11:13:03 PST
Comment on attachment 75169 [details]
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation

Anders Carlsson reviewed this.
Comment 4 mitz 2010-11-30 11:18:16 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/72937>.
Comment 5 Adam Roben (:aroben) 2010-12-01 09:23:39 PST
It looks like findString still isn't exposed to JS: <http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r73025%20(5430)/editing/text-iterator/findString-pretty-diff.html>

I think findString needs to be added to LayoutTestController.idl.
Comment 6 mitz 2010-12-01 09:54:27 PST
(In reply to comment #5)
> It looks like findString still isn't exposed to JS: <http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r73025%20(5430)/editing/text-iterator/findString-pretty-diff.html>
> 
> I think findString needs to be added to LayoutTestController.idl.

I don’t see this failure when I do
$ WebKitTestRunner LayoutTests/editing/text-iterator/findString.html

Any idea why?
Comment 7 mitz 2010-12-01 10:29:34 PST
Created attachment 75288 [details]
Generate bindings for findString
Comment 9 Eric Seidel (no email) 2010-12-14 01:29:25 PST
Comment on attachment 75169 [details]
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation

Cleared Dan Bernstein's review+ from obsolete attachment 75169 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 10 Eric Seidel (no email) 2010-12-14 01:30:09 PST
Sounds like this is resolved?