Bug 51507 - [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
Summary: [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be over...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks: 51151
  Show dependency tree / graph
 
Reported: 2010-12-22 16:33 PST by Mihai Parparita
Modified: 2010-12-23 14:59 PST (History)
9 users (show)

See Also:

Attachments
Patch (13.64 KB, patch)
2010-12-22 16:43 PST, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch for landing (14.24 KB, patch)
2010-12-23 10:34 PST, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-22 16:33:19 PST 
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
Comment 1 Mihai Parparita 2010-12-22 16:43:54 PST 
Created attachment 77276 [details]
Patch
Comment 2 Mihai Parparita 2010-12-22 16:59:05 PST 
Chromium side is at http://codereview.chromium.org/6041005
Comment 3 Mihai Parparita 2010-12-22 17:06:22 PST 
+Kent since he reviewed the Linux version of WebThemeEngine (http://trac.webkit.org/changeset/69311).
Comment 4 Kent Tamura 2010-12-23 04:40:01 PST 
Comment on attachment 77276 [details]
Patch

Looks good.
Comment 5 Kent Tamura 2010-12-23 04:42:46 PST 
Comment on attachment 77276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77276&action=review

> WebKit/chromium/public/mac/WebThemeEngine.h:1
> +/*

We should add this file to WebKit.gyp.
Comment 6 Mihai Parparita 2010-12-23 10:34:35 PST 
Created attachment 77346 [details]
Patch for landing
Comment 7 Mihai Parparita 2010-12-23 10:35:05 PST 
(In reply to comment #5)
> We should add this file to WebKit.gyp.

Done.
Comment 8 WebKit Commit Bot 2010-12-23 14:24:16 PST 
Comment on attachment 77346 [details]
Patch for landing

Clearing flags on attachment: 77346

Committed r74581: <http://trac.webkit.org/changeset/74581>
Comment 9 WebKit Commit Bot 2010-12-23 14:24:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2010-12-23 14:59:35 PST 
http://trac.webkit.org/changeset/74581 might have broken GTK Linux 64-bit Debug