RESOLVED FIXED 52168
Title of standalone image document includes bogus image dimensions 
https://bugs.webkit.org/show_bug.cgi?id=52168
Summary Title of standalone image document includes bogus image dimensions
Adam Roben (:aroben)
Reported 2011-01-10 13:09:25 PST
Title of standalone image document includes bogus image dimensions
Attachments
Patch (2.27 KB, patch)
2011-01-10 13:10 PST, Adam Roben (:aroben) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-01-10 13:10:34 PST
Created attachment 78439 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-10 13:53:59 PST
Comment on attachment 78439 [details] Patch Um. I guess rs=me. Crazy.
Adam Roben (:aroben)
Comment 3 2011-01-10 14:05:09 PST
Committed r75435: <http://trac.webkit.org/changeset/75435>
Darin Adler
Comment 4 2011-01-10 14:36:00 PST
Comment on attachment 78439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review > WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:55 > +// Note that because |format| is used as the second paramter to va_start, it cannot be a reference Misspelled parameter here.
Darin Adler
Comment 5 2011-01-10 14:40:28 PST
Comment on attachment 78439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review > WebKit2/ChangeLog:5 > + Don't pass a reference type to va_start > + > + C++ says this results in undefined behavior: Makes total sense. The macro uses the "&" operator, which does something surprising with a reference type.
Note You need to log in before you can comment on or make changes to this bug.