Bug 52168 - Title of standalone image document includes bogus image dimensions
Summary: Title of standalone image document includes bogus image dimensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-01-10 13:09 PST by Adam Roben (:aroben)
Modified: 2011-01-10 14:40 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2011-01-10 13:10 PST, Adam Roben (:aroben) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-01-10 13:09:25 PST 
Title of standalone image document includes bogus image dimensions
Comment 1 Adam Roben (:aroben) 2011-01-10 13:10:34 PST 
Created attachment 78439 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-10 13:53:59 PST 
Comment on attachment 78439 [details]
Patch

Um.  I guess rs=me.  Crazy.
Comment 3 Adam Roben (:aroben) 2011-01-10 14:05:09 PST 
Committed r75435: <http://trac.webkit.org/changeset/75435>
Comment 4 Darin Adler 2011-01-10 14:36:00 PST 
Comment on attachment 78439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review

> WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:55
> +// Note that because |format| is used as the second paramter to va_start, it cannot be a reference

Misspelled parameter here.
Comment 5 Darin Adler 2011-01-10 14:40:28 PST 
Comment on attachment 78439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review

> WebKit2/ChangeLog:5
> +        Don't pass a reference type to va_start
> +
> +        C++ says this results in undefined behavior:

Makes total sense. The macro uses the "&" operator, which does something surprising with a reference type.