WKCACFLayerRenderer is hard to use
Created attachment 79185 [details] Patch
Comment on attachment 79185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review r=me, assuming the animationStarted logic is actually working. But I don't see anywhere in this patch where it's getting called. > Source/WebCore/ChangeLog:8 > + accomplished in other ways.) What other ways? > WebKit/win/WebView.cpp:-6520 > - Who is calling notifyAnimationStarted now?
Comment on attachment 79185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review >> Source/WebCore/ChangeLog:8 >> + accomplished in other ways.) > > What other ways? http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp?rev=75262#L469 I'll note this in the ChangeLog. >> WebKit/win/WebView.cpp:-6520 >> - > > Who is calling notifyAnimationStarted now? See above. :-)
(In reply to comment #3) > (From update of attachment 79185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review > > >> Source/WebCore/ChangeLog:8 > >> + accomplished in other ways.) > > > > What other ways? > > http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp?rev=75262#L469 > > I'll note this in the ChangeLog. Thanks. > > >> WebKit/win/WebView.cpp:-6520 > >> - > > > > Who is calling notifyAnimationStarted now? > > See above. :-) I made that change 10 days ago. You expect me to remember something like that? :-) I was confused because I tried doing this several different ways. The code you axed was just a victim I didn't clean up.
Committed r75988: <http://trac.webkit.org/changeset/75988>