Bug 52752 - WKCACFContextFlusher is unused
Summary: WKCACFContextFlusher is unused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-01-19 15:00 PST by Adam Roben (:aroben)
Modified: 2011-01-20 09:15 PST (History)
3 users (show)

See Also:

Attachments
Remove WKCACFContextFlusher (16.81 KB, patch)
2011-01-19 15:01 PST, Adam Roben (:aroben) 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-01-19 15:00:11 PST 
WKCACFContextFlusher is unused
Comment 1 Adam Roben (:aroben) 2011-01-19 15:01:32 PST 
Created attachment 79494 [details]
Remove WKCACFContextFlusher
Comment 2 Simon Fraser (smfr) 2011-01-19 15:04:34 PST 
Comment on attachment 79494 [details]
Remove WKCACFContextFlusher

View in context: https://bugs.webkit.org/attachment.cgi?id=79494&action=review

Yay!

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:43752
>  			</File>
>  			<File

Are all these changes benign? Why does Visual Studio do this??
Comment 3 Adam Roben (:aroben) 2011-01-19 15:08:22 PST 
Comment on attachment 79494 [details]
Remove WKCACFContextFlusher

View in context: https://bugs.webkit.org/attachment.cgi?id=79494&action=review

>> Source/WebCore/WebCore.vcproj/WebCore.vcproj:43752
>>  			<File
> 
> Are all these changes benign? Why does Visual Studio do this??

They are benign. I think they're due to people hand-editing the file and doing it slightly differently from how Visual Studio would like.
Comment 4 Build Bot 2011-01-19 15:15:41 PST 
Attachment 79494 [details] did not build on win:
Build output: http://queues.webkit.org/results/7522198
Comment 5 Adam Roben (:aroben) 2011-01-19 15:18:21 PST 
(In reply to comment #4)
> Attachment 79494 [details] did not build on win:
> Build output: http://queues.webkit.org/results/7522198

Quit yer whinin'. I just haven't committed the fix for bug 52751 yet.
Comment 6 Adam Roben (:aroben) 2011-01-20 09:15:40 PST 
Committed r76258: <http://trac.webkit.org/changeset/76258>