Bug 53353 - build-webkit gives a bogus warning with newer versions of Xcode
Summary: build-webkit gives a bogus warning with newer versions of Xcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 16:29 PST by David Kilzer (:ddkilzer)
Modified: 2011-01-28 16:53 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2011-01-28 16:29 PST, David Kilzer (:ddkilzer) 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-01-28 16:29:40 PST 
Created attachment 80523 [details]
Patch

Reviewed by NOBODY (OOPS!).

* Scripts/webkitdirs.pm:
(checkRequiredSystemConfig): Check the Xcode marketing version
in addition to the DevCoreTools build version before complaining
about an old version of Xcode.  Also make the Mac OS X version
check use Perl's built-in version string comparitor.
---
 2 files changed, 19 insertions(+), 3 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2011-01-28 16:52:21 PST 
Committed r77028: <http://trac.webkit.org/changeset/77028>
Comment 2 David Kilzer (:ddkilzer) 2011-01-28 16:53:50 PST 
Added bug link to ChangeLog:

Committed r77030: <http://trac.webkit.org/changeset/77030>