Bug 53777 - Asynchronous client-based proposed implementation for the device element
Summary: Asynchronous client-based proposed implementation for the device element
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Leandro Graciá Gil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 09:31 PST by Leandro Graciá Gil
Modified: 2012-09-19 07:19 PDT (History)
9 users (show)

See Also:

Attachments
Patch (120.91 KB, patch)
2011-02-04 09:41 PST, Leandro Graciá Gil 		no flags Details | Formatted Diff | Diff
Class diagram of the proposed model. (35.60 KB, application/pdf)
2011-02-04 13:29 PST, Leandro Graciá Gil 		no flags Details
Diagram for the local device successful connection/disconnection use case. (49.75 KB, application/pdf)
2011-02-09 13:09 PST, Leandro Graciá Gil 		no flags Details
Patch (132.79 KB, patch)
2011-02-09 13:10 PST, Leandro Graciá Gil 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Graciá Gil 2011-02-04 09:31:00 PST 
This is the implementation for our proposed design for the device element. This patch is not intended to be reviewed or directly submitted, but to be used to understand our proposal. If accepted, this is intended to be uploaded in a set of small, easy to review patches for which https://bugs.webkit.org/show_bug.cgi?id=53595 and https://bugs.webkit.org/show_bug.cgi?id=53776 should be the first and second one.

ChangeLogs and the mock-related code have been left out of this patch.
Comment 1 Leandro Graciá Gil 2011-02-04 09:41:00 PST 
Created attachment 81234 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-04 09:44:35 PST 
Attachment 81234 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/Configurations/Featu..." exit_code: 1

Source/WebCore/dom/DeviceConnection.h:76:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2011-02-04 10:55:19 PST 
Attachment 81234 [details] did not build on win:
Build output: http://queues.webkit.org/results/7694912
Comment 4 Leandro Graciá Gil 2011-02-04 13:29:43 PST 
Created attachment 81277 [details]
Class diagram of the proposed model.
Comment 5 Leandro Graciá Gil 2011-02-09 13:09:20 PST 
Created attachment 81854 [details]
Diagram for the local device successful connection/disconnection use case.
Comment 6 Leandro Graciá Gil 2011-02-09 13:10:15 PST 
Created attachment 81855 [details]
Patch
Comment 7 Build Bot 2011-02-09 15:13:19 PST 
Attachment 81855 [details] did not build on win:
Build output: http://queues.webkit.org/results/7884047