Bug 53779 - Remove last vestiges of JSVALUE32
Summary: Remove last vestiges of JSVALUE32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 09:40 PST by David Kilzer (:ddkilzer)
Modified: 2011-02-04 17:28 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.34 KB, patch)
2011-02-04 09:40 PST, David Kilzer (:ddkilzer)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-02-04 09:40:03 PST
Created attachment 81233 [details]
Patch

Reviewed by NOBODY (OOPS!).

Support for JSVALUE32 was originaly removed in r70111.

* Configurations/JavaScriptCore.xcconfig: Changed armv6 to use
JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.
* DerivedSources.make: Removed rule for
JavaScriptCore.JSVALUE32.exp.
* JavaScriptCore.JSVALUE32only.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed references
to JavaScriptCore.JSVALUE32only.exp.
---
 5 files changed, 19 insertions(+), 9 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2011-02-04 10:13:24 PST
Committed r77638: <http://trac.webkit.org/changeset/77638>
Comment 2 David Kilzer (:ddkilzer) 2011-02-04 13:11:02 PST
Clean build fix:  (In reply to comment #1)
> Committed r77638: <http://trac.webkit.org/changeset/77638>

Build fix:  Committed r77662: <http://trac.webkit.org/changeset/77662>
Comment 3 WebKit Review Bot 2011-02-04 17:28:38 PST
http://trac.webkit.org/changeset/77662 might have broken GTK Linux 32-bit Debug and GTK Linux 64-bit Debug
The following tests are not passing:
fast/blockflow/Kusa-Makura-background-canvas.html
fast/blockflow/japanese-ruby-horizontal-bt.html
fast/blockflow/japanese-ruby-vertical-lr.html
fast/blockflow/japanese-ruby-vertical-rl.html
fast/ruby/nested-ruby.html
fast/text/emphasis-avoid-ruby.html