Bug 53780 - Crash log links in results.html should include the function that crashed on Mac
Summary: Crash log links in results.html should include the function that crashed on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-04 09:46 PST by Adam Roben (:aroben)
Modified: 2011-02-04 10:02 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2011-02-04 09:47 PST, Adam Roben (:aroben) 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-04 09:46:29 PST 
Crash log links in results.html should include the function that crashed on Mac
Comment 1 Adam Roben (:aroben) 2011-02-04 09:47:25 PST 
Created attachment 81235 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-02-04 09:52:07 PST 
Comment on attachment 81235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81235&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:2017
> +            $location = $functionAndOffset;

You should return "$module: $functionAndOffset" to match Windows here.
Comment 3 Adam Roben (:aroben) 2011-02-04 10:02:06 PST 
Committed r77636: <http://trac.webkit.org/changeset/77636>