Bug 53826 - react-to-vsprops-changes.py doesn't force precompiled headers to be rebuilt, but should
Summary: react-to-vsprops-changes.py doesn't force precompiled headers to be rebuilt, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/builders/Wind...
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-04 17:08 PST by Adam Roben (:aroben)
Modified: 2011-02-07 08:04 PST (History)
2 users (show)

See Also:


Attachments
Delete precompiled headers whenever any .vsprops file changes (4.72 KB, patch)
2011-02-07 07:36 PST, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-04 17:08:55 PST
r77677 made a change to common.vsprops that required a clean build to be performed. react-to-vsprops-changes.py noticed the change and touched wtf/Platform.h like it is supposed to. But the build failed anyway because precompiled headers didn't get rebuilt.

It looks like we need to make react-to-vsprops-changes.py more aggressive in forcing a rebuild. Perhaps we should touch the precompiled headers themselves, or delete their compiled versions.
Comment 1 Adam Roben (:aroben) 2011-02-07 07:36:56 PST
Created attachment 81470 [details]
Delete precompiled headers whenever any .vsprops file changes
Comment 2 David Kilzer (:ddkilzer) 2011-02-07 07:45:36 PST
Comment on attachment 81470 [details]
Delete precompiled headers whenever any .vsprops file changes

r=me
Comment 3 Adam Roben (:aroben) 2011-02-07 08:04:24 PST
Committed r77815: <http://trac.webkit.org/changeset/77815>